Since Spectre / Meltdown, system calls have become more expensive. In
addition, relevant versions of glibc turn out to implement pthread_cond_wait
and pthread_cond_signal in such a way that they use multiple system calls always.
There is an optimization in glibc to improve this but it is disabled.
This new setup changes our protobuf logging so it amortizes system calls so we perform
far less than one call per message.
Note that our previous RemoteLogger was configured in terms of how many
messages it would buffer. Our new code is configured in terms of how many
bytes. I have multiplied the configured numbers by 100 elsewhere (recursor
config, dnsdist config) to sort of maintain parity.
In addition, the old RemoteLogger would buffer messages while there was no
connection available. We no longer do this.
Finally new, every ‘reconnectTimeout’ seconds we will flush our buffers
opportunistically to not keep people waiting.
- #7434: Add an option to export only responses over protobuf
- #7430: Reduce systemcall usage in protobuf logging